Skip to content

8372753: jpackage ignores --file-associations option with predefined app image #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexeysemenyukoracle wants to merge 2 commits into from
Closed

8372753: jpackage ignores --file-associations option with predefined app image #395

alexeysemenyukoracle wants to merge 2 commits into from

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Nov 29, 2025 •
edited by openjdk bot
Loading

Fix handling of the --file-associations option when bundling from the predefined app image. Add relevant tests.

This is a regression from JDK-8333664. It is JDK25-specific and doesn't affect JDK26, as it handles command line options differently due to the JDK-8333727 fix.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372753 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8372753: jpackage ignores --file-associations option with predefined app image

Issue

  • JDK-8372753: jpackage ignores --file-associations option with predefined app image (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/395/head:pull/395
$ git checkout pull/395

Update a local copy of the PR:
$ git checkout pull/395
$ git pull https://git.openjdk.org/jdk25u.git pull/395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 395

View PR using the GUI difftool:
$ git pr show -t 395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/395.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 29, 2025 •
edited
Loading

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372753: jpackage ignores --file-associations option with predefined app image

Reviewed-by: almatvee, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cdbdbdc: 8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Nov 29, 2025

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2025 •
edited
Loading

Webrevs

@alexeysemenyukoracle alexeysemenyukoracle deleted the JDK-8372753 branch November 29, 2025 00:58
@alexeysemenyukoracle alexeysemenyukoracle restored the JDK-8372753 branch November 29, 2025 00:58
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as draft November 29, 2025 01:01
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 29, 2025
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review November 29, 2025 01:05
@alexeysemenyukoracle alexeysemenyukoracle changed the title 8372753: jpackage ignres --file-associations option with predefined app image 8372753: jpackage ignores --file-associations option with predefined app image Nov 29, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2025
@alexeysemenyukoracle
Copy link
Member Author

alexeysemenyukoracle commented Dec 1, 2025

@aivanov-jdk please review

@alexeysemenyukoracle
Copy link
Member Author

alexeysemenyukoracle commented Dec 1, 2025

@sashamatveev please review

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 1, 2025
sashamatveev
sashamatveev approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Dec 2, 2025
azuev-java
azuev-java approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2025
@alexeysemenyukoracle
Copy link
Member Author

alexeysemenyukoracle commented Dec 2, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 2, 2025
@openjdk
Copy link

openjdk bot commented Dec 2, 2025

@alexeysemenyukoracle
Your change (at version 29d6096) is now ready to be sponsored by a Committer.

@azuev-java
Copy link
Member

azuev-java commented Dec 2, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 2, 2025

Going to push as commit d306ab9.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cdbdbdc: 8370649: Add intermittent tag for gc/shenandoah/generational/TestOldGrowthTriggers.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2025
@openjdk openjdk bot closed this Dec 2, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 2, 2025
@openjdk
Copy link

openjdk bot commented Dec 2, 2025

@azuev-java @alexeysemenyukoracle Pushed as commit d306ab9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sashamatveev sashamatveev sashamatveev approved these changes

@azuev-java azuev-java azuev-java approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexeysemenyukoracle @azuev-java @sashamatveev